This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Fix property names & default values in README #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're right! Thanks for the fix @kshvmdn. |
nguyenthienthanh
pushed a commit
to nguyenthienthanh/react-native-photo-browser
that referenced
this pull request
Dec 28, 2017
…tive-photo-browser * 'master' of https://github.com/nguyenthienthanh/react-native-photo-browser: (84 commits) fixed custom style BarComponent add the custom title in full-screen mode add the custom title in full-screen mode bumped version replaced navigator with react-navigation Long press params (halilb#62) Using ViewPropTypes.styles (halilb#69) upgraded the example project to RN 0.50 fix(package): Added react-native-deprecated-custom-components fix(example): Navigator component has been deprecated add listview props allow custom title compute function update current index add prefetch and custom render photo function Fix prop. names & default values in README (halilb#56) update topbar reverting paddingTop change Only show TopBar if displayTopBar is true (halilb#55) added prop-types dependency Use prop-types library (halilb#52) ... # Conflicts: # .eslintrc # .gitignore # .npmignore # Assets/angle-left.png # Assets/angle-left@2x.png # Assets/angle-left@3x.png # Assets/arrow-left@2x copy.png # Assets/arrow-left@2x.png # Assets/arrow-left@3x.png # Assets/arrow-right@2x copy.png # Assets/arrow-right@2x.png # Assets/arrow-right@3x.png # Assets/grid-button@2x copy.png # Assets/grid-button@2x.png # Assets/grid-button@3x.png # Assets/hourglass.png # Assets/hourglass@2x.png # Assets/hourglass@3x.png # Assets/image-error.png # Assets/image-error@2x.png # Assets/image-error@3x.png # Assets/selected-off.png # Assets/selected-off@2x.png # Assets/selected-off@3x.png # Assets/selected-on.png # Assets/selected-on@2x.png # Assets/selected-on@3x.png # Assets/share-button@2x.png # Assets/share-button@3x copy.png # Assets/share-button@3x.png # Assets/small-selected-off.png # Assets/small-selected-off@2x.png # Assets/small-selected-off@3x.png # Assets/small-selected-on.png # Assets/small-selected-on@2x.png # Assets/small-selected-on@3x.png # Example/.babelrc # Example/.buckconfig # Example/.flowconfig # Example/.gitattributes # Example/.gitignore # Example/.watchmanconfig # Example/DetailScreen.js # Example/HomeScreen.js # Example/android/app/BUCK # Example/android/app/build.gradle # Example/android/app/proguard-rules.pro # Example/android/app/react.gradle # Example/android/app/src/main/AndroidManifest.xml # Example/android/app/src/main/java/com/photobrowserexample/MainActivity.java # Example/android/app/src/main/java/com/photobrowserexample/MainApplication.java # Example/android/app/src/main/res/mipmap-hdpi/ic_launcher.png # Example/android/app/src/main/res/mipmap-mdpi/ic_launcher.png # Example/android/app/src/main/res/mipmap-xhdpi/ic_launcher.png # Example/android/app/src/main/res/mipmap-xxhdpi/ic_launcher.png # Example/android/app/src/main/res/values/strings.xml # Example/android/app/src/main/res/values/styles.xml # Example/android/build.gradle # Example/android/gradle.properties # Example/android/gradle/wrapper/gradle-wrapper.jar # Example/android/gradle/wrapper/gradle-wrapper.properties # Example/android/gradlew.bat # Example/android/keystores/BUCK # Example/android/keystores/debug.keystore.properties # Example/android/settings.gradle # Example/app.json # Example/index.js # Example/ios/PhotoBrowserExample-tvOS/Info.plist # Example/ios/PhotoBrowserExample-tvOSTests/Info.plist # Example/ios/PhotoBrowserExample.xcodeproj/project.pbxproj # Example/ios/PhotoBrowserExample.xcodeproj/xcshareddata/xcschemes/PhotoBrowserExample-tvOS.xcscheme # Example/ios/PhotoBrowserExample.xcodeproj/xcshareddata/xcschemes/PhotoBrowserExample.xcscheme # Example/ios/PhotoBrowserExample/AppDelegate.h # Example/ios/PhotoBrowserExample/AppDelegate.m # Example/ios/PhotoBrowserExample/Base.lproj/LaunchScreen.xib # Example/ios/PhotoBrowserExample/Images.xcassets/AppIcon.appiconset/Contents.json # Example/ios/PhotoBrowserExample/Images.xcassets/Contents.json # Example/ios/PhotoBrowserExample/Info.plist # Example/ios/PhotoBrowserExample/main.m # Example/ios/PhotoBrowserExampleTests/Info.plist # Example/ios/PhotoBrowserExampleTests/PhotoBrowserExampleTests.m # Example/media/broadchurch_thumbnail.png # Example/package.json # Example/yarn.lock # LICENCE # README.md # lib/FullScreenContainer.js # lib/bar/BarContainer.js # lib/bar/BottomBar.js # lib/bar/TopBar.js # lib/bar/index.js # lib/constants.js # lib/index.js # lib/media/Photo.js # lib/media/index.js # package.json # screenshots/photo-browser.gif # screenshots/screenshot-1.png # screenshots/screenshot-2.png
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following errors in prop. documentation:
displayStatusBarshould bealwaysDisplayStatusBaralwaysDisplayStatusBarhas default value offalsedisplayTopBarhas default value oftrue