This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Fix InitialIndex Bug + Switch from ListView -> FlatList #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue with ListView initial index not working on iOS due to "contentOffset" bug. ListView is no longer supported, so switch to FlatList where the issue is fixed. Repro: 1) Create Viewer and set initialIndex to a non-zero value. After the viewer loads try swiping left or right. Notice the number at the top resets to 0. Also notice that the image doesn't load correctly.
Fix issue with ListView initial index w/ switch to FlatList
|
@halilb - ping |
…d use Scroll/FlatList too?) Fix references to scrolllist-> flatlist for android. Android doesn't use flat list tho... it uses ViewPagerAndroid... might make sense to just switch both to using the same thing in the future. Functionality seems identical.
ngandhy
changed the title
|
Thanks for this @ngandhy. This looks good. And I'm so sorry for the late review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
Repro:
Solution: