test: refactor tests (#369)

packages/windows_ai/test/collections_test.dart

@@ -123,4 +123,6 @@ void main() {
       expect(newList.last, equals(1.5));
     });
   }, skip: getWindowsBuildNumber() < 18362);
+
+  tearDownAll(forceGC);
 }

packages/windows_data/test/collections_test.dart

@@ -7,6 +7,7 @@
 import 'package:test/test.dart';
 import 'package:win32/win32.dart';
 import 'package:windows_data/windows_data.dart';
+import 'package:windows_foundation/internal.dart';
 import 'package:windows_foundation/windows_foundation.dart';
 
 void main() {
@@ -188,4 +189,6 @@ void main() {
       expect(map.lookup('key6')?.stringify(), equals('{"hello":"world"}'));
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_devices/test/collections_test.dart

@@ -7,6 +7,7 @@
 import 'package:test/test.dart';
 import 'package:win32/win32.dart';
 import 'package:windows_devices/windows_devices.dart';
+import 'package:windows_foundation/internal.dart';
 import 'package:windows_foundation/windows_foundation.dart';
 
 void main() {
@@ -308,4 +309,6 @@ void main() {
           ]));
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/lib/src/internal/helpers.dart

@@ -2,6 +2,8 @@
 // All rights reserved. Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
+import 'dart:async';
+import 'dart:developer';
 import 'dart:ffi';
 
 import 'package:ffi/ffi.dart';
@@ -12,6 +14,29 @@ import '../winrt_enum.dart';
 import '../winrt_struct.dart';
 import 'extensions/extensions.dart';
 
+/// Forces garbage collection through aggressive memory allocation.
+///
+/// Used to ensure `Finalizer`s run after all tests within a file.
+///
+/// Its purpose is to prevent any potential occurrences of "double free" or
+/// "use after free" errors in the projection.
+/// @nodoc
+Future<void> forceGC({int fullGcCycles = 2}) async {
+  final barrier = reachabilityBarrier;
+
+  final storage = <List<int>>[];
+
+  void allocateMemory() {
+    storage.add(List.generate(30000, (n) => n));
+    if (storage.length > 100) storage.removeAt(0);
+  }
+
+  while (reachabilityBarrier < barrier + fullGcCycles) {
+    await Future<void>.delayed(Duration.zero);
+    allocateMemory();
+  }
+}
+
 /// Returns the restricted error description of the last error that occurred on
 /// the current logical thread.
 ///
@@ -54,6 +79,7 @@ String? getRestrictedErrorDescription(int hresult) {
 }
 
 /// Returns the Windows build number of the current system.
+/// @nodoc
 int getWindowsBuildNumber() {
   final key = Registry.openPath(RegistryHive.localMachine,
       path: r'Software\Microsoft\Windows NT\CurrentVersion');

packages/windows_foundation/test/collections/imap_test.dart

@@ -6,6 +6,7 @@
 
 import 'package:test/test.dart';
 import 'package:win32/win32.dart';
+import 'package:windows_foundation/internal.dart';
 import 'package:windows_foundation/windows_foundation.dart';
 
 void main() {
@@ -46,4 +47,6 @@ void main() {
       expect(map.lookup('key3'), equals('value3'));
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/collections/imapview_test.dart

@@ -114,4 +114,6 @@ void main() {
       expect(map['key3'], equals('value3'));
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/collections/ivector_test.dart

@@ -347,4 +347,6 @@ void main() {
           ]));
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/collections/propertyset_test.dart

@@ -6,6 +6,7 @@
 
 import 'package:test/test.dart';
 import 'package:win32/win32.dart';
+import 'package:windows_foundation/internal.dart';
 import 'package:windows_foundation/windows_foundation.dart';
 
 void main() {
@@ -108,9 +109,10 @@ void main() {
       final dateTimeListVal = map.lookup('key14');
       expect(dateTimeListVal, isA<List<DateTime>>());
       final dateTimeList = dateTimeListVal as List<DateTime>;
-      expect(dateTimeList.first.millisecondsSinceEpoch,
+      final [dateTime1, dateTime2] = dateTimeList;
+      expect(dateTime1.millisecondsSinceEpoch,
           equals(DateTime(2020, 7, 11, 17, 30).millisecondsSinceEpoch));
-      expect(dateTimeList.last.millisecondsSinceEpoch,
+      expect(dateTime2.millisecondsSinceEpoch,
           equals(DateTime(2022, 7, 11, 17, 30).millisecondsSinceEpoch));
 
       expect(map.lookup('key15'), equals([2.5, 0.99]));
@@ -267,4 +269,6 @@ void main() {
       expect(map.lookup('key24'), equals(24));
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/collections/stringmap_test.dart

@@ -6,6 +6,7 @@
 
 import 'package:test/test.dart';
 import 'package:win32/win32.dart';
+import 'package:windows_foundation/internal.dart';
 import 'package:windows_foundation/windows_foundation.dart';
 
 void main() {
@@ -151,4 +152,6 @@ void main() {
       expect(map.lookup('key4'), equals('value4'));
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/collections/valueset_test.dart

@@ -116,9 +116,10 @@ void main() {
       final dateTimeListVal = map.lookup('key14');
       expect(dateTimeListVal, isA<List<DateTime>>());
       final dateTimeList = dateTimeListVal as List<DateTime>;
-      expect(dateTimeList.first.millisecondsSinceEpoch,
+      final [dateTime1, dateTime2] = dateTimeList;
+      expect(dateTime1.millisecondsSinceEpoch,
           equals(DateTime(2020, 7, 11, 17, 30).millisecondsSinceEpoch));
-      expect(dateTimeList.last.millisecondsSinceEpoch,
+      expect(dateTime2.millisecondsSinceEpoch,
           equals(DateTime(2022, 7, 11, 17, 30).millisecondsSinceEpoch));
 
       expect(map.lookup('key15'), equals([2.5, 0.99]));
@@ -268,4 +269,6 @@ void main() {
       expect(map.lookup('key23'), equals(23));
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/extensions/iunknown_helpers_test.dart

@@ -6,6 +6,7 @@
 
 import 'package:test/test.dart';
 import 'package:win32/win32.dart';
+import 'package:windows_foundation/internal.dart';
 import 'package:windows_foundation/uri.dart' as winrt_uri;
 import 'package:windows_foundation/windows_foundation.dart';
 
@@ -40,4 +41,6 @@ void main() {
       expect(stringMap.tryCast(IPropertySet.fromPtr, IID_IPropertySet), isNull);
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/helpers_test.dart

@@ -8,6 +8,7 @@ import 'dart:ffi';
 
 import 'package:test/test.dart';
 import 'package:win32/win32.dart' hide IUnknown;
+import 'package:windows_foundation/internal.dart';
 import 'package:windows_foundation/windows_foundation.dart';
 
 void main() {
@@ -46,6 +47,10 @@ void main() {
     expect(refCount(calendar), equals(1));
   });
 
+  test('forceGC', () {
+    expect(() async => forceGC(), returnsNormally);
+  });
+
   test('getWindowHandle', () {
     expect(getWindowHandle(), isZero);
   });
@@ -58,4 +63,6 @@ void main() {
     propertySet.release();
     expect(refCount(propertySet), 1);
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/internal/extensions/bool_test.dart

@@ -54,4 +54,6 @@ void main() {
     expect(list, orderedEquals([true, false]));
     free(array);
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/internal/extensions/datetime_test.dart

@@ -80,4 +80,6 @@ void main() {
       free(array);
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/internal/extensions/double_test.dart

@@ -76,4 +76,6 @@ void main() {
     expect(list, orderedEquals([1.0, 2.5]));
     free(array);
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/internal/extensions/duration_test.dart

@@ -80,4 +80,6 @@ void main() {
       free(array);
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/internal/extensions/enum_test.dart

@@ -50,4 +50,6 @@ void main() {
         list, orderedEquals([FileAttributes.normal, FileAttributes.directory]));
     free(array);
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/internal/extensions/guid_test.dart

@@ -59,4 +59,6 @@ void main() {
     expect(list, orderedEquals([guid1, guid2]));
     allocator.releaseAll();
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/internal/extensions/int_test.dart

@@ -71,4 +71,6 @@ void main() {
       expect(list, orderedEquals([0, 9223372036854775807]));
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/internal/extensions/ipropertyvalue_test.dart

@@ -37,12 +37,13 @@ void main() {
       final value = pv.value;
       expect(value, isA<List<Object?>>());
       final list = value as List<Object?>;
-      expect(list.first, isA<IInspectable>());
-      final firstObject = list.first as IInspectable;
+      final [element1, element2] = list;
+      expect(element1, isA<IInspectable>());
+      final firstObject = element1 as IInspectable;
       expect(getClassName(firstObject),
           equals('Windows.Foundation.Collections.PropertySet'));
-      expect(list.last, isA<IInspectable>());
-      final secondObject = list.last as IInspectable;
+      expect(element2, isA<IInspectable>());
+      final secondObject = element2 as IInspectable;
       expect(getClassName(secondObject),
           equals('Windows.Foundation.Collections.StringMap'));
     });
@@ -62,4 +63,6 @@ void main() {
       expect(value, orderedEquals(['Hello', 'World']));
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/internal/extensions/object_test.dart

@@ -70,9 +70,10 @@ void main() {
       expect(pv.type, equals(PropertyType.inspectableArray));
       final list = pv.getInspectableArray();
       expect(list.length, equals(2));
-      expect(list.first, isA<Uri>());
-      expect(list.first.toString(), equals('https://dartwinrt.dev/'));
-      expect(list.last, isNull);
+      final [element1, element2] = list;
+      expect(element1, isA<Uri>());
+      expect(element1.toString(), equals('https://dartwinrt.dev/'));
+      expect(element2, isNull);
     });
 
     test('String', () {
@@ -201,4 +202,6 @@ void main() {
       expect(list[8], isA<Uri>());
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/internal/extensions/string_test.dart

@@ -107,4 +107,6 @@ void main() {
     expect(list, orderedEquals(['d', '\x00', ' ', r'$']));
     free(array);
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/internal/extensions/struct_test.dart

@@ -82,4 +82,6 @@ void main() {
     expect(list.length, equals(2));
     expect(list, orderedEquals([size1, size2]));
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/internal/extensions/uri_test.dart

@@ -75,4 +75,6 @@ void main() {
       expect(winrtUri.host, equals('dartwinrt.dev'));
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/internal/hstring_test.dart

@@ -108,4 +108,6 @@ void main() {
       }
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/ireference_test.dart

@@ -125,4 +125,6 @@ void main() {
       expect(reference.value, equals('Hello World'));
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/memorybuffer_test.dart

@@ -6,6 +6,7 @@
 
 import 'package:test/test.dart';
 import 'package:win32/win32.dart';
+import 'package:windows_foundation/internal.dart';
 import 'package:windows_foundation/windows_foundation.dart';
 
 void main() {
@@ -18,6 +19,7 @@ void main() {
     test('create', () {
       final buffer = MemoryBuffer.create(10);
       expect(buffer.addRef(), equals(2));
+      expect(buffer.release(), equals(1));
       buffer.close();
     });
 
@@ -30,4 +32,6 @@ void main() {
       buffer.close();
     });
   });
+
+  tearDownAll(forceGC);
 }

packages/windows_foundation/test/propertyvalue_test.dart

@@ -398,4 +398,6 @@ void main() {
       expect(pv.value, equals([10000, 20000, 30000, 40000, 50000]));
     });
   });
+
+  tearDownAll(forceGC);
 }