Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: throw better errors #360

Merged
merged 1 commit into from
Aug 7, 2023
Merged

refactor: throw better errors #360

merged 1 commit into from
Aug 7, 2023

Conversation

halildurmus
Copy link
Owner

Description

Related Issue

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🧪 test -- Test
  • 🗑️ chore -- Chore

@halildurmus halildurmus added the type: refactor Refactor an existing implementation label Aug 7, 2023
@github-actions github-actions bot added pkg: windows_data The windows_data package pkg: windows_devices The windows_devices package pkg: windows_foundation The windows_foundation package pkg: windows_globalization The windows_globalization package pkg: windows_graphics The windows_graphics package pkg: windows_media The windows_media package pkg: windows_networking The windows_networking package pkg: windows_storage The windows_storage package pkg: winrtgen The winrtgen package pkg: windows_ai The windows_ai package labels Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #360 (1809f7e) into main (28c4758) will increase coverage by 0.04%.
The diff coverage is 31.91%.

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   83.21%   83.26%   +0.04%     
==========================================
  Files         106      105       -1     
  Lines        5355     5347       -8     
==========================================
- Hits         4456     4452       -4     
+ Misses        899      895       -4     
Files Changed Coverage Δ
...dows_foundation/lib/src/collections/iiterator.dart 34.14% <0.00%> (ø)
...indows_foundation/lib/src/collections/ivector.dart 50.00% <0.00%> (ø)
...ws_foundation/lib/src/collections/ivectorview.dart 34.31% <0.00%> (ø)
...es/windows_foundation/lib/src/iasyncoperation.dart 0.00% <0.00%> (ø)
...foundation/lib/src/internal/extensions/double.dart 96.15% <0.00%> (ø)
...ws_foundation/lib/src/internal/extensions/int.dart 90.90% <0.00%> (ø)
...foundation/lib/src/internal/extensions/string.dart 100.00% <ø> (ø)
...ackages/windows_foundation/lib/src/ireference.dart 56.52% <0.00%> (ø)
packages/winrtgen/lib/src/extensions/string.dart 100.00% <ø> (ø)
packages/winrtgen/lib/src/extensions/typedef.dart 92.85% <0.00%> (ø)
... and 23 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@halildurmus halildurmus merged commit 30b06da into main Aug 7, 2023
44 of 45 checks passed
@halildurmus halildurmus deleted the exceptions branch August 7, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: windows_ai The windows_ai package pkg: windows_data The windows_data package pkg: windows_devices The windows_devices package pkg: windows_foundation The windows_foundation package pkg: windows_globalization The windows_globalization package pkg: windows_graphics The windows_graphics package pkg: windows_media The windows_media package pkg: windows_networking The windows_networking package pkg: windows_storage The windows_storage package pkg: winrtgen The winrtgen package type: refactor Refactor an existing implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant