Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: use .cast extension method in .from factory ctors #366

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

halildurmus
Copy link
Owner

Description

Related Issue

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🧪 test -- Test
  • 🗑️ chore -- Chore

@halildurmus halildurmus added the type: refactor Refactor an existing implementation label Aug 11, 2023
@github-actions github-actions bot added pkg: windows_data The windows_data package pkg: windows_devices The windows_devices package pkg: windows_foundation The windows_foundation package pkg: windows_gaming The windows_gaming package pkg: windows_globalization The windows_globalization package pkg: windows_graphics The windows_graphics package pkg: windows_media The windows_media package pkg: windows_networking The windows_networking package pkg: windows_storage The windows_storage package pkg: windows_system The windows_system package pkg: windows_ui The windows_ui package pkg: winrtgen The winrtgen package pkg: windows_security The windows_security package pkg: windows_ai The windows_ai package pkg: windows_perception The windows_perception package pkg: windows_applicationmodel The windows_applicationmodel package labels Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #366 (e1e1a11) into main (364ae5a) will not change coverage.
The diff coverage is 57.14%.

@@           Coverage Diff           @@
##             main     #366   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files          85       85           
  Lines        4098     4098           
=======================================
  Hits         3807     3807           
  Misses        291      291           
Files Changed Coverage Δ
...ws_foundation/lib/src/collections/propertyset.dart 83.33% <ø> (ø)
...dows_foundation/lib/src/collections/stringmap.dart 86.66% <ø> (ø)
...ndows_foundation/lib/src/collections/valueset.dart 86.66% <ø> (ø)
...kages/windows_foundation/lib/src/iasyncaction.dart 0.00% <0.00%> (ø)
...ackages/windows_foundation/lib/src/iasyncinfo.dart 0.00% <0.00%> (ø)
...ges/windows_foundation/lib/src/ipropertyvalue.dart 99.45% <0.00%> (ø)
...ages/windows_foundation/lib/src/propertyvalue.dart 99.00% <ø> (ø)
packages/windows_foundation/lib/src/uri.dart 100.00% <ø> (ø)
.../windows_foundation/lib/src/wwwformurldecoder.dart 100.00% <ø> (ø)
packages/windows_foundation/lib/src/iclosable.dart 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@halildurmus halildurmus merged commit fc8db7b into main Aug 11, 2023
40 of 41 checks passed
@halildurmus halildurmus deleted the cast branch August 11, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: windows_ai The windows_ai package pkg: windows_applicationmodel The windows_applicationmodel package pkg: windows_data The windows_data package pkg: windows_devices The windows_devices package pkg: windows_foundation The windows_foundation package pkg: windows_gaming The windows_gaming package pkg: windows_globalization The windows_globalization package pkg: windows_graphics The windows_graphics package pkg: windows_media The windows_media package pkg: windows_networking The windows_networking package pkg: windows_perception The windows_perception package pkg: windows_security The windows_security package pkg: windows_storage The windows_storage package pkg: windows_system The windows_system package pkg: windows_ui The windows_ui package pkg: winrtgen The winrtgen package type: refactor Refactor an existing implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant