Fix Bash expansion in kubeconfig path of CLI script #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pizzapim
changed the title
pkgs/kubenix.nix
Outdated
| --set KUBECONFIG "${kubeconfig}" \ | ||
| --set KUBECTL_EXTERNAL_DIFF "''${DIFF}" \ | ||
| --set MANIFEST "${result}" | ||
| --run 'export KUBECONFIG=${kubeconfig}' \ |
There was a problem hiding this comment.
how about this, so user can still overwrite KUBECONFIG at runtime?
Suggested change
| --run 'export KUBECONFIG=${kubeconfig}' \ | |
| --run 'export KUBECONFIG=''${KUBECONFIG:-${kubeconfig}}' \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous change had a regression where
$HOMEinkubernetes.kubeconfigwould be expanded at build-time.This is because
--set KUBECONFIG "${kubeconfig}"(wherekubeconfig = "$HOME/.kube/config") would evaluate to--set KUBECONFIG "/home/homeless-shelter/.kube/config"at build-time.We also cannot do
--set KUBECONFIG '${kubeconfig}'becausewrapProgramrenders this asexport KUBECONFIG='$HOME/.kube/config'.Note the single quotes, which prevents expansion of
$HOME.A solution here is to avoid using
--setaltogether and use--runwith any quotes instead, which allows to expand~as well.