Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS 12.3 doesn't ship with python2, time to migrate to python3 #67

Closed
alistra opened this issue Mar 16, 2022 · 5 comments · Fixed by #72
Closed

macOS 12.3 doesn't ship with python2, time to migrate to python3 #67

alistra opened this issue Mar 16, 2022 · 5 comments · Fixed by #72
Labels

Comments

@alistra
Copy link

alistra commented Mar 16, 2022

The script runner of git-format-staged is using env python in its shebang which is used for Python 2.

Python 2 is no longer supported and there was a long time to migrate.

Please migrate to python 3 with the runner script :)

PS I'm not asking for tips how to install python2

@victorBaro
Copy link

Any updates on this?

@hallettj
Copy link
Owner

hallettj commented Mar 18, 2022 via email

@alistra
Copy link
Author

alistra commented Mar 18, 2022

@hallettj probably just changing the env python to env python3 would be sufficient and releasing, the comment claims it works under python 3

hallettj added a commit that referenced this issue Mar 20, 2022
I'm told that the correct thing to do is to run Python scripts with `python3` since `python` continues to reference v2. Fixes #67.

This change also updates the CI testing matrix to test against Python versions 3.10, 3.9, and 2.7.

BREAKING CHANGE: git-format-staged now runs with `python3` instead of `python`. You will need to have `python3` in your executable path.
@hallettj
Copy link
Owner

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hallettj
Copy link
Owner

Thank you for submitting the issue! I really appreciate the help to make sure that this program continues to work for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants