Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: halo-dev/halo#1119 #264

Merged
merged 10 commits into from
Nov 2, 2020
Merged

feat: halo-dev/halo#1119 #264

merged 10 commits into from
Nov 2, 2020

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 22, 2020

@ruibaby ruibaby added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 22, 2020
@ruibaby ruibaby self-assigned this Oct 22, 2020
@ruibaby ruibaby marked this pull request as draft October 22, 2020 14:19
@ruibaby ruibaby marked this pull request as ready for review October 29, 2020 16:43
@ruibaby ruibaby requested a review from guqing October 29, 2020 16:43
@guqing
Copy link
Member

guqing commented Oct 30, 2020

image
这个功能忘记写了

@guqing
Copy link
Member

guqing commented Oct 30, 2020

image
被操作的Item按钮应该一直显示会好一点 不然会觉得奇怪

@guqing
Copy link
Member

guqing commented Oct 30, 2020

image

拍完序后需要点保存按钮才会生效,我感觉要么排完了就直接保存 或者离开的时候提示保存,排完序直接保存会好一点

@guqing
Copy link
Member

guqing commented Oct 30, 2020

image
新增弹窗只有刷新页面后第一次点击会自动聚焦,而后就不会,算是个小小的问题

@guqing
Copy link
Member

guqing commented Oct 30, 2020

image
添加了很多菜单分组 离开没有保存,如果是逻辑如此该加个提示会好一点,不然会以为是保存有问题

@ruibaby
Copy link
Member Author

ruibaby commented Oct 30, 2020

image
这个功能忘记写了

好的

@guqing
Copy link
Member

guqing commented Oct 30, 2020

image
像这样分组很多是否考虑分组也支持排序,这样在页面显示的时候可以按照分组的排序显示菜单

@guqing
Copy link
Member

guqing commented Oct 30, 2020

@ruibaby 我以为前端显示会按照目录来作为第一层 目录下的为子菜单

@ruibaby ruibaby merged commit 701e379 into halo-dev:master Nov 2, 2020
@ruibaby ruibaby deleted the feat/halo-#1119 branch November 2, 2020 14:35
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
2 participants