Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: add upgrade theme support #653

Merged
merged 1 commit into from Oct 24, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 20, 2022

What type of PR is this?

/kind feature
/milestone 2.0

What this PR does / why we need it:

支持升级主题。适配 halo-dev/halo#2600

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2550

Screenshots:

image

image

Special notes for your reviewer:

测试方式:

  1. Halo 需要切换到 Provide an endpoint to upgrade theme halo#2600
  2. 需要 pnpm install
  3. 测试更主题功能是否正常。

Does this PR introduce a user-facing change?

支持升级主题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 20, 2022
@vercel
Copy link

vercel bot commented Oct 20, 2022

@ruibaby is attempting to deploy a commit to the halo-dev Team on Vercel.

A member of the Team first needs to authorize it.

@f2c-ci-robot f2c-ci-robot bot added this to the 2.0 milestone Oct 20, 2022
@vercel
Copy link

vercel bot commented Oct 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
halo-admin-next ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 3:15AM (UTC)
halo-admin-ui ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 3:15AM (UTC)

@ruibaby
Copy link
Member Author

ruibaby commented Oct 21, 2022

/cc @halo-dev/sig-halo-console

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2022
@ruibaby
Copy link
Member Author

ruibaby commented Oct 22, 2022

/cc @halo-dev/sig-halo-console

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 48daa1a into halo-dev:main Oct 24, 2022
@ruibaby ruibaby deleted the feat/add-upgrade-theme-support branch November 19, 2022 16:11
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
#### What type of PR is this?

/kind feature
/milestone 2.0

#### What this PR does / why we need it:

支持升级主题。适配 halo-dev#2600

#### Which issue(s) this PR fixes:

Fixes halo-dev#2550

#### Screenshots:

<img width="915" alt="image" src="https://user-images.githubusercontent.com/21301288/196875056-cb0fbb7d-1cfd-47c3-ae6a-5e76c642b51d.png">
<img width="915" alt="image" src="https://user-images.githubusercontent.com/21301288/196875083-39e3778c-4925-4cb9-befc-563f40c77d06.png">

#### Special notes for your reviewer:

测试方式:

1. Halo 需要切换到 halo-dev#2600
2. 需要 `pnpm install`
3. 测试更主题功能是否正常。

#### Does this PR introduce a user-facing change?

```release-note
支持升级主题。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
3 participants