Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: automatically refresh the list when it has data that is being deleted #661

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 24, 2022

What type of PR is this?

/kind feature
/milestone 2.0

What this PR does / why we need it:

优化部分数据列表的逻辑,支持在检测出有正在删除的数据时,自动定时刷新列表。

Special notes for your reviewer:

/cc @halo-dev/sig-halo-console

测试方式:

  1. 进入任意一个数据列表,比如文章。
  2. 删除一个文章,观察是否有自动刷新列表。
  3. 切换路由,检查自动刷新是否停止。

Does this PR introduce a user-facing change?

优化部分数据列表的逻辑,支持在检测出有正在删除的数据时,自动定时刷新列表。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 24, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.0 milestone Oct 24, 2022
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 24, 2022
@vercel
Copy link

vercel bot commented Oct 24, 2022

@ruibaby is attempting to deploy a commit to the halo-dev Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
halo-admin-next ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 9:57AM (UTC)
halo-admin-ui ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 9:57AM (UTC)

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well!

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 8b6c70e into halo-dev:main Oct 24, 2022
@ruibaby ruibaby deleted the feat/auto-refresh-list branch November 19, 2022 16:10
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…eleted (halo-dev/console#661)

#### What type of PR is this?

/kind feature
/milestone 2.0

#### What this PR does / why we need it:

优化部分数据列表的逻辑,支持在检测出有正在删除的数据时,自动定时刷新列表。

#### Special notes for your reviewer:

/cc @halo-dev/sig-halo-console 

测试方式:

1. 进入任意一个数据列表,比如文章。
2. 删除一个文章,观察是否有自动刷新列表。
3. 切换路由,检查自动刷新是否停止。

#### Does this PR introduce a user-facing change?

```release-note
优化部分数据列表的逻辑,支持在检测出有正在删除的数据时,自动定时刷新列表。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
3 participants