This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
refactor: load the logo as an inline svg #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
the
release-note
f2c-ci-robot
bot
added
the
kind/improvement
|
@ruibaby is attempting to deploy a commit to the halo-dev Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
|
/lgtm |
1 similar comment
|
/lgtm |
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
#### What type of PR is this? /kind improvement /milestone 2.0 #### What this PR does / why we need it: 以 inline svg 的形式加载 Logo，解决因为加载 svg 文件导致的页面抖动问题。 #### Special notes for your reviewer: /cc @halo-dev/sig-halo-console 测试方式：检查登录页面、初始化页面、侧边菜单顶部的 Logo 是否加载正常。 #### Does this PR introduce a user-facing change? ```release-note 以 inline svg 的形式加载 Logo，解决因为加载 svg 文件导致的页面抖动问题。 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/milestone 2.0
What this PR does / why we need it:
以 inline svg 的形式加载 Logo，解决因为加载 svg 文件导致的页面抖动问题。
Special notes for your reviewer:
/cc @halo-dev/sig-halo-console
测试方式：检查登录页面、初始化页面、侧边菜单顶部的 Logo 是否加载正常。
Does this PR introduce a user-facing change?