Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

chore: bump @halo-dev/richtext-editor to fix iframe display and add HTML syntax highlighting #773

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 15, 2022

What type of PR is this?

/kind improvement

What this PR does / why we need it:

升级 @halo-dev/richtext-editor 版本,解决以下问题:

  1. 修复嵌入网页不会回显的问题。 halo-sigs/richtext-editor@c8cfe8f
  2. 添加 HTML 语法的代码块高亮。 halo-sigs/richtext-editor@8d27ae8

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2924
Fixes halo-dev/halo#2913

Special notes for your reviewer:

测试方式:

  1. 需要 pnpm install
  2. 插件编辑器的代码块是否有 HTML 语言选项。
  3. 插入一个嵌入网页的编辑块,保存文章之后再次进入编辑页面,检查加载是否正常。

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 15, 2022
@vercel
Copy link

vercel bot commented Dec 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 3:02AM (UTC)

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit c95af5b into halo-dev:main Dec 16, 2022
@ruibaby ruibaby deleted the chore/bump-editor-version-to-17 branch December 16, 2022 03:09
@ruibaby
Copy link
Member Author

ruibaby commented Dec 16, 2022

/cherry-pick release-2.0

@halo-dev-bot
Copy link

@ruibaby: new pull request created: #776

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Dec 16, 2022
…play and add HTML syntax highlighting (#776)

This is an automated cherry-pick of #773

/assign ruibaby

```release-note
None
```
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…TML syntax highlighting (halo-dev/console#773)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

升级 `@halo-dev/richtext-editor` 版本,解决以下问题:

1. 修复嵌入网页不会回显的问题。 halo-sigs/richtext-editor@c8cfe8f
2. 添加 HTML 语法的代码块高亮。 halo-sigs/richtext-editor@8d27ae8

#### Which issue(s) this PR fixes:

Fixes halo-dev#2924
Fixes halo-dev#2913

#### Special notes for your reviewer:

测试方式:

1. 需要 `pnpm install`
2. 插件编辑器的代码块是否有 HTML 语言选项。
3. 插入一个嵌入网页的编辑块,保存文章之后再次进入编辑页面,检查加载是否正常。

#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
4 participants