Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: add support for resetting configmap of plugin and theme #777

Merged
merged 4 commits into from Dec 19, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 16, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

支持重置主题和插件的设置选项。适配 halo-dev/halo#2964

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2789

Screenshots:

image

Special notes for your reviewer:

测试方式:

  1. 安装若干带有设置选项主题和插件。
  2. 进入主题和插件设置,改变部分设置并保存。
  3. 重置主题和插件的设置,然后进入设置表单,检查是否已经恢复为了默认。

Does this PR introduce a user-facing change?

支持重置主题和插件的设置选项。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 16, 2022
@vercel
Copy link

vercel bot commented Dec 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Dec 19, 2022 at 6:57AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 16, 2022
@guqing
Copy link
Member

guqing commented Dec 19, 2022

需要重新生成一下 API client,see halo-dev/halo@6fe7c76

package.json Outdated Show resolved Hide resolved
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
It works very well 🎉

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2022
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在合并前,需要解决一下冲突。

@ruibaby
Copy link
Member Author

ruibaby commented Dec 19, 2022

在合并前,需要解决一下冲突。

Done

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 0a7cbd3 into halo-dev:main Dec 19, 2022
@ruibaby ruibaby deleted the feat/reset-plugin-theme-configmap branch December 19, 2022 08:40
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…ev/console#777)

#### What type of PR is this?

/kind feature

#### What this PR does / why we need it:

支持重置主题和插件的设置选项。适配 halo-dev#2964

#### Which issue(s) this PR fixes:

Fixes halo-dev#2789

#### Screenshots:

<img width="366" alt="image" src="https://user-images.githubusercontent.com/21301288/208022668-288fb8c5-ddd1-456c-9633-ec8865f3b1ba.png">

#### Special notes for your reviewer:

测试方式:

1. 安装若干带有设置选项主题和插件。
2. 进入主题和插件设置,改变部分设置并保存。
3. 重置主题和插件的设置,然后进入设置表单,检查是否已经恢复为了默认。

#### Does this PR introduce a user-facing change?

```release-note
支持重置主题和插件的设置选项。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
3 participants