Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: optimize the operation button style of the entity component #780

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 16, 2022

What type of PR is this?

/kind improvement

What this PR does / why we need it:

优化 Entity 组件(数据列表)的操作按钮样式。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2971

Screenshots:

before:

image

after:

image

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

优化 Console 端数据列表的操作按钮样式

@vercel
Copy link

vercel bot commented Dec 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 9:24AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Dec 16, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2022
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

似乎还是没有效果。下面的截图是在 Firefox 浏览器浏览的结果:

image

@ruibaby
Copy link
Member Author

ruibaby commented Dec 19, 2022

似乎还是没有效果。下面的截图是在 Firefox 浏览器浏览的结果:

image

image

需要选择或者将鼠标放在上面才会添加背景颜色。

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 03d2b5a into halo-dev:main Dec 19, 2022
@ruibaby ruibaby deleted the perf/entity-dropdown-button branch December 19, 2022 03:19
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…lo-dev/console#780)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

优化 Entity 组件(数据列表)的操作按钮样式。

#### Which issue(s) this PR fixes:

Fixes halo-dev#2971

#### Screenshots:

before:

![image](https://user-images.githubusercontent.com/21301288/208065926-9e0fb332-4075-43cf-b75f-4d040c80ccfa.png)


after:

<img width="1658" alt="image" src="https://user-images.githubusercontent.com/21301288/208066185-a48d5f84-e451-4fc7-9eea-b152ddb8db86.png">



#### Special notes for your reviewer:

None

#### Does this PR introduce a user-facing change?


```release-note
优化 Console 端数据列表的操作按钮样式
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
3 participants