Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

Differentiate the title of adding and editing menu and menu item #794

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

chengfeiyue
Copy link
Contributor

@chengfeiyue chengfeiyue commented Dec 22, 2022

What type of PR is this?

/kind improvement

What this PR does / why we need it:

新增和修改菜单时,标题都为编辑菜单,存在歧义

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3022

Special notes for your reviewer:

测试方式:新增菜单和菜单项。然后再编辑菜单和菜单项,查看title是否一样

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Dec 22, 2022
@vercel
Copy link

vercel bot commented Dec 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Dec 22, 2022 at 6:14AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 22, 2022
@CLAassistant
Copy link

CLAassistant commented Dec 22, 2022

CLA assistant check
All committers have signed the CLA.

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 22, 2022
@JohnNiang
Copy link
Member

/retitle Differentiate the title of adding and editing menu and menu item

@f2c-ci-robot f2c-ci-robot bot changed the title Fix:新增和编辑菜单时title一样,存在歧义 Differentiate the title of adding and editing menu and menu item Dec 22, 2022
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Nice Work

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit c6a0f2d into halo-dev:main Dec 22, 2022
@chengfeiyue chengfeiyue deleted the fix_menu_bug branch December 22, 2022 09:50
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…o-dev/console#794)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

新增和修改菜单时,标题都为编辑菜单,存在歧义

#### Which issue(s) this PR fixes:

Fixes halo-dev#3022

#### Special notes for your reviewer:

测试方式:新增菜单和菜单项。然后再编辑菜单和菜单项,查看title是否一样

#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
5 participants