Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: google analytics settings #42

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 18, 2022

修复因错误配置导致 Google Analytics 无法统计的问题。

see facebook/docusaurus#5832

Signed-off-by: Ryan Wang i@ryanc.cc

Signed-off-by: Ryan Wang <i@ryanc.cc>
@netlify
Copy link

netlify bot commented Feb 18, 2022

✔️ Deploy Preview for halo-docs ready!

🔨 Explore the source changes: 91672d9

🔍 Inspect the deploy log: https://app.netlify.com/sites/halo-docs/deploys/620f0dd78f7792000796c1b3

😎 Browse the preview: https://deploy-preview-42--halo-docs.netlify.app

@ruibaby ruibaby self-assigned this Feb 18, 2022
@ruibaby ruibaby added the kind/bug Categorizes issue or PR as related to a bug. label Feb 18, 2022
@JohnNiang
Copy link
Member

修复因错误配置导致 Google Analytics 无法统计的问题。

有相关的文档可以提供么?

@ruibaby
Copy link
Member Author

ruibaby commented Feb 18, 2022

修复因错误配置导致 Google Analytics 无法统计的问题。

有相关的文档可以提供么?

facebook/docusaurus#5832

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruibaby ruibaby merged commit 019aae4 into halo-dev:main Feb 18, 2022
@ruibaby ruibaby deleted the fix/google-analytics-setting branch February 18, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants