Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: photoTag listByTeam example #84

Merged
merged 2 commits into from
Aug 1, 2022
Merged

fix: photoTag listByTeam example #84

merged 2 commits into from
Aug 1, 2022

Conversation

vayci
Copy link
Contributor

@vayci vayci commented Jul 30, 2022 •
edited by ruibaby
Loading

Fixes #85

None

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 30, 2022
@netlify
Copy link

netlify bot commented Jul 30, 2022 •
edited
Loading

✅ Deploy Preview for halo-docs ready!

Name Link
🔨 Latest commit 0a4df47
🔍 Latest deploy log https://app.netlify.com/sites/halo-docs/deploys/62e7c4ba9b41fd00084019cf
😎 Deploy Preview https://deploy-preview-84--halo-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vayci vayci closed this Jul 30, 2022
@ruibaby ruibaby mentioned this pull request Aug 1, 2022
Closed
@vayci vayci reopened this Aug 1, 2022
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 1, 2022
@ruibaby
Copy link
Member

ruibaby commented Aug 1, 2022

这属于一个修复，可能需要同时修改一下 https://github.com/halo-dev/docs/blob/main/versioned_docs/version-1.5.4/developer-guide/theme/template-tag.md 中的对应内容。

@vayci
Copy link
Contributor Author

vayci commented Aug 1, 2022

这属于一个修复，可能需要同时修改一下 https://github.com/halo-dev/docs/blob/main/versioned_docs/version-1.5.4/developer-guide/theme/template-tag.md 中的对应内容。

稍后补充对于当前1.5.4版本相关文档修改。

@vayci
Copy link
Contributor Author

vayci commented Aug 1, 2022

1.5.4版本文档相关内容也进行了修改。

ruibaby
ruibaby reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

感谢参与贡献。

/cc @halo-dev/sig-docs

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022
guqing
guqing reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit e855dda into halo-dev:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby left review comments

@guqing guqing guqing left review comments

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

@QuentinHsu QuentinHsu Awaiting requested review from QuentinHsu

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

图库根据分组获取图片（listByTeam）示例错误
3 participants
@vayci @ruibaby @guqing