Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

chore: add pull request template #569

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 16, 2022

What type of PR is this?

/kind documentation

What this PR does / why we need it:

规范 Pull Request 的提交,以及支持生成 Release Notes。

Which issue(s) this PR fixes:

Fixes #

Screenshots:

Special notes for your reviewer:

/cc @halo-dev/sig-halo-admin

Does this PR introduce a user-facing change?

NONE

@auto-assign auto-assign bot requested review from guqing, JohnNiang and LIlGG May 16, 2022 05:51
@f2c-ci-robot f2c-ci-robot bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 16, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 16, 2022

@ruibaby: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 16, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 16, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from ruibaby after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby
Copy link
Member Author

ruibaby commented May 16, 2022

/hold

pnpm-lock.yaml 似乎被修改。

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2022
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby ruibaby force-pushed the chore/add-pull-request-template branch from e32004b to b6115dd Compare May 16, 2022 05:53
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 16, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from ruibaby after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby
Copy link
Member Author

ruibaby commented May 16, 2022

/hold

pnpm-lock.yaml 似乎被修改。

/unhold

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 16, 2022
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit dfd445f into halo-dev:master May 16, 2022
@ruibaby ruibaby deleted the chore/add-pull-request-template branch May 16, 2022 06:43
f2c-ci-robot bot pushed a commit that referenced this pull request Oct 9, 2022
…635)

#### What type of PR is this?

/kind documentation

#### What this PR does / why we need it:

添加 PR 模板和删除 auto assign 的配置文件。 Ref #569

#### Special notes for your reviewer:

/cc @halo-dev/sig-halo-console 

#### Does this PR introduce a user-facing change?

```release-note
None
```
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…alo-dev/console#635)

#### What type of PR is this?

/kind documentation

#### What this PR does / why we need it:

添加 PR 模板和删除 auto assign 的配置文件。 Ref halo-dev/console#569

#### Special notes for your reviewer:

/cc @halo-dev/sig-halo-console 

#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
3 participants