Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

删除附件分组时通过 Reconciler 去删除附件 #2710

Open
guqing opened this issue Nov 17, 2022 · 2 comments
Open

删除附件分组时通过 Reconciler 去删除附件 #2710

guqing opened this issue Nov 17, 2022 · 2 comments
Assignees
Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@guqing
Copy link
Member

guqing commented Nov 17, 2022

Your current Halo version

2.0.0-alpha.4

Describe this feature

目前删除附件的逻辑是 Console 端处理的:

  1. 选择删除并将附件移动至未分组时,会在前端批量调用更新附件的接口,将所有附件的 groupRef 置空。
  2. 选择删除并同时删除附件时,会在前端批量调用删除附件接口。

但调用API去删除分组下面的附件,附件过多时删除分组将会导致页面卡死或崩溃。

期望在 Group 中加上 finalizer,如果删除 Group 则在 reconciler 中先删除其下的所有附件,再移除 finalizer。
如果需要让用户决定是否级联删除附件,可以在 Group 中加上 spec.cascadeDelete=false 字段。

更多信息参考:

Additional information

/kind improvement
/area core
/label priority/critical-urgent

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. area/core Issues or PRs related to the Halo Core labels Nov 17, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 17, 2022

@guqing: The label(s) kind/priority/critical-urgent cannot be applied, because the repository doesn't have them.

In response to this:

Your current Halo version

2.0.0-alpha.4

Describe this feature

目前删除附件的逻辑是 Console 端处理的:

  1. 选择删除并将附件移动至未分组时,会在前端批量调用更新附件的接口,将所有附件的 groupRef 置空。
  2. 选择删除并同时删除附件时,会在前端批量调用删除附件接口。

但调用API去删除分组下面的附件,附件过多时删除分组将会导致页面卡死或崩溃。

期望在 Group 中加上 finalizer,如果删除 Group 则在 reconciler 中先删除其下的所有附件,再移除 finalizer。
如果需要让用户决定是否级联删除附件,可以在 Group 中加上 spec.cascadeDelete=false 字段。

更多信息参考 halo-dev/console#695

Additional information

/kind improvement
/area core
/kind priority/critical-urgent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guqing guqing added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 17, 2022
@JohnNiang
Copy link
Member

/assign

@JohnNiang JohnNiang added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Nov 21, 2022
@ruibaby ruibaby added this to the 2.3.x milestone Feb 2, 2023
@ruibaby ruibaby modified the milestones: 2.3.x, 2.4.x Feb 23, 2023
@ruibaby ruibaby modified the milestones: 2.4.x, Backlog Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants