Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

附件 #4326

Closed
cetr opened this issue Jul 28, 2023 · 4 comments · Fixed by #4328
Closed

附件 #4326

cetr opened this issue Jul 28, 2023 · 4 comments · Fixed by #4328
Assignees
@Erzbir
Labels
area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug.
Milestone
2.8.0

Comments

@cetr
Copy link
Member

cetr commented Jul 28, 2023

是什么版本出现了此问题？

2.7.0

使用的什么数据库？

PostgreSQL

使用的哪种方式部署？

Docker Compose

在线站点地址

No response

发生了什么？

image

如图所示，附件“最后一张”图片点击下一个后，会返回空值，https://demo.halo.run 里也可测试出来

相关日志输出

No response

附加信息

No response
@Erzbir
Copy link
Contributor

Erzbir commented Jul 29, 2023

我的也出现了

@Erzbir
Copy link
Contributor

Erzbir commented Jul 29, 2023 •
edited

最后一个附件再点下一个会出现:
截屏2023-07-29 14 14 14

看了代码, 逻辑是 index === data.value.length - 1 && hasNext 为 true 则 page++

改成 index === data.value.length - 1 && hasNext.value 可以避免

/assign

@ruibaby
Copy link
Member

ruibaby commented Jul 29, 2023

/kind bug
/area console
/milestone 2.8.x

@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 29, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.8.x milestone Jul 29, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Jul 29, 2023
@Erzbir Erzbir mentioned this issue Jul 29, 2023
Merged
@JohnNiang
Copy link
Member

/assign @Erzbir

f2c-ci-robot bot pushed a commit that referenced this issue Jul 29, 2023
@Erzbir
fix: click "next" on the last attachment will get null (#4328)
8e0538e 
#### What type of PR is this?

/kind bug
/area console
/milestone 2.8.x

#### What this PR does / why we need it:

修复在最后一个附件点击 "下一个" 时, 附件库内容全部消失或得到一个 "空" 附件, 且不能 "往前"

#### Which issue(s) this PR fixes:

Fixes #4326

#### Special notes for your reviewer:
1. 上传附件
2. 一直点击 "下一个" 直到最后一张
3. 在最后一张再点击下一个, 观察页面是否出现异常, 正常情况下会停在最后一个附件上且页面不会有刷新

#### Does this PR introduce a user-facing change?

```release-note
修复 Console 端在最后一个附件点击下一项按钮时得到空结果的问题。
```
@ruibaby ruibaby modified the milestones: 2.8.x, 2.8.0 Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erzbir Erzbir

Labels
area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.8.0
Development

Successfully merging a pull request may close this issue.

fix: click "next" on the last attachment will get null Erzbir/halo
4 participants
@JohnNiang @ruibaby @cetr @Erzbir