Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console 端插件详情选项卡扩展在没有插件设置时不生效 #4633

Closed
ruibaby opened this issue Sep 20, 2023 · 1 comment · Fixed by #4659
Closed

Console 端插件详情选项卡扩展在没有插件设置时不生效 #4633

ruibaby opened this issue Sep 20, 2023 · 1 comment · Fixed by #4659
Assignees
@ruibaby
Labels
area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug.
Milestone
2.10.0

Comments

@ruibaby
Copy link
Member

ruibaby commented Sep 20, 2023

是什么版本出现了此问题？

2.9.1

使用的什么数据库？

H2

使用的哪种方式部署？

Docker

在线站点地址

https://halo.run

发生了什么？

文档：https://github.com/halo-dev/halo/blob/main/console/docs/extension-points/plugin-self-tabs.md

目前发现，在插件没有定义设置选项（settings.yaml）时，此扩展无法生效，即不会显示扩展的选项卡。

image

/kind bug
/area console
/milestone 2.10.x

相关日志输出

No response

附加信息

No response
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 20, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 20, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Sep 20, 2023
@ruibaby
Copy link
Member Author

ruibaby commented Sep 20, 2023

/assign

@ruibaby ruibaby mentioned this issue Sep 25, 2023
Merged
f2c-ci-robot bot pushed a commit that referenced this issue Sep 25, 2023
@ruibaby
fix: plugin self tab extension point not working when no setting defi…
927e45b 
…nition (#4659)

#### What type of PR is this?

/area console
/kind bug
/milestone 2.10.x

#### What this PR does / why we need it:

修复当插件没有设置表单定义时，详情选项卡扩展点不生效的问题。

<img width="1061" alt="image" src="https://github.com/halo-dev/halo/assets/21301288/01abc565-a55e-40d5-9d2b-41a7eab2d9b5">

#### Which issue(s) this PR fixes:

Fixes #4633

#### Special notes for your reviewer:

可以通过以下插件进行测试：

1. [plugin-migrate-1.2.0-SNAPSHOT.jar.zip](https://github.com/halo-dev/halo/files/12713261/plugin-migrate-1.2.0-SNAPSHOT.jar.zip)
2. https://github.com/halo-dev/plugin-app-store/releases/tag/v1.0.0-alpha.4
3. https://github.com/halo-dev/plugin-s3

#### Does this PR introduce a user-facing change?

```release-note
None
```
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruibaby ruibaby

Labels
area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.10.0
Development

Successfully merging a pull request may close this issue.

fix: plugin self tab extension point not working when no setting definition ruibaby/halo
1 participant
@ruibaby