Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New formkit component "secret" will fulfill secret data into config instead of secret name only #6193

Closed
JohnNiang opened this issue Jun 28, 2024 · 1 comment · Fixed by #6196
Assignees
Labels
area/core Issues or PRs related to the Halo Core area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@JohnNiang
Copy link
Member

System information

Local dev env.

What is the project operation method?

Source Code

What happened?

Please see the following config data:

{
    "data": {
        "basic": "{\"secretName\":\"algolia-search-engine-secret\",\"slots\":{},\"secret-form\":{\"description\":\"Algolia 搜索引擎密钥\",\"stringDataArray\":[{\"key\":\"apiKey\",\"value\":\"xxx\"},{\"key\":\"appId\",\"value\":\"yyy\"},{\"key\":\"undefined\",\"value\":\"\"}]},\"indexName\":\"halo\"}"
    },
    "apiVersion": "v1alpha1",
    "kind": "ConfigMap",
    "metadata": {
        "name": "algolia-search-engine-config",
        "version": 7,
        "creationTimestamp": "2024-06-25T09:46:21.334351Z"
    }
}

In the config data, secret data were saved into config data.

Relevant log output

No response

Additional information

/kind bug
/area core
/milestone 2.17.x

@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jun 28, 2024
@ruibaby ruibaby self-assigned this Jun 28, 2024
@ruibaby
Copy link
Member

ruibaby commented Jun 28, 2024

/area ui

@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot closed this as completed in bae53f5 Jun 29, 2024
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues or PRs related to the Halo Core area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants