Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue with secret input saving additional data #6196

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 28, 2024

What type of PR is this?

/kind bug
/area ui
/milestone 2.17.x

What this PR does / why we need it:

修复 Secret Input 保存之后会多出 Secret Form 中数据的问题。

Which issue(s) this PR fixes:

Fixes #6193

Special notes for your reviewer:

测试方式:

  1. 在保存 Secret 的表单选项前,打开一次编辑 Secret 的对话框。
  2. 保存数据,检查内容是否多出了其他数据。

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG June 28, 2024 05:12
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.02%. Comparing base (bc10336) to head (9d2bfe9).
Report is 32 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6196      +/-   ##
============================================
+ Coverage     54.51%   57.02%   +2.51%     
- Complexity     3523     3717     +194     
============================================
  Files           646      651       +5     
  Lines         21862    22041     +179     
  Branches       1528     1542      +14     
============================================
+ Hits          11917    12568     +651     
+ Misses         9328     8866     -462     
+ Partials        617      607      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2024
Copy link

f2c-ci-robot bot commented Jun 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit bae53f5 into halo-dev:main Jun 29, 2024
7 checks passed
@ruibaby ruibaby deleted the fix/prevent-children-form branch June 29, 2024 16:36
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New formkit component "secret" will fulfill secret data into config instead of secret name only
2 participants