Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the redirected URL will be garbled when include Chinese #1786

Merged
merged 1 commit into from Mar 29, 2022

Conversation

guqing
Copy link
Member

@guqing guqing commented Mar 29, 2022

What this PR does?

修复文章和分类的url带有中文时加密功能从密码页重定向到详情url由于乱码跳转不过去的问题

Why we need it?

Fix #1784

How to test it?

发布一篇机密文章或分类然后访问它输入密码后期望能正确跳转到文章或分类详情

/kind bug
/cc @halo-dev/sig-halo

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 29, 2022
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@ruibaby
Copy link
Member

ruibaby commented Mar 29, 2022

/kind bug

/milestone 1.5.x

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 489ffc8 into halo-dev:master Mar 29, 2022
@guqing guqing deleted the bugfix/url-encoding branch April 15, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

版本升级1.4.5 版本升级到 1.5.0 加密显示 404
2 participants