Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Spring Boot to 3.0.0-RC1 #2620

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Oct 23, 2022

What type of PR is this?

/kind improvement
/area core
/milestone 2.0

What this PR does / why we need it:

Special notes for reviewers

We have removed ThemeJava8TimeDialect due to removal of thymeleaf-extras-java8time module in thymeleaf/thymeleaf#912

Does this PR introduce a user-facing change?

None

Signed-off-by: johnniang <johnniang@fastmail.com>
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Oct 23, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.0 milestone Oct 23, 2022
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 23, 2022
@JohnNiang JohnNiang changed the title Bump Spring Boot to 3.0.0-RC1 WIP: Bump Spring Boot to 3.0.0-RC1 Oct 23, 2022
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2022
Signed-off-by: johnniang <johnniang@fastmail.com>
@JohnNiang JohnNiang changed the title WIP: Bump Spring Boot to 3.0.0-RC1 Bump Spring Boot to 3.0.0-RC1 Oct 24, 2022
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2022
@JohnNiang JohnNiang changed the title Bump Spring Boot to 3.0.0-RC1 WIP: Bump Spring Boot to 3.0.0-RC1 Oct 24, 2022
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2022
Signed-off-by: johnniang <johnniang@fastmail.com>
@JohnNiang JohnNiang changed the title WIP: Bump Spring Boot to 3.0.0-RC1 Bump Spring Boot to 3.0.0-RC1 Oct 24, 2022
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2022
@JohnNiang
Copy link
Member Author

/ping @halo-dev/sig-halo

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit d2aa707 into halo-dev:main Oct 25, 2022
@JohnNiang JohnNiang deleted the chore/upgrade-spring-boot branch October 26, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants