feat: create reverse proxy for logo when plugin created #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/improvement
ruibaby
reviewed
Nov 2, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
f2c-ci-robot bot
pushed a commit
to halo-dev/console
that referenced
this pull request
Nov 3, 2022
#### What type of PR is this? /kind improvement /milestone 2.0 #### What this PR does / why we need it: 修改插件 Logo 的使用字段为 `status.logo`。用于适配 halo-dev/halo#2652 #### Which issue(s) this PR fixes: Fixes halo-dev/halo#2651 #### Screenshots: <img width="1663" alt="image" src="https://user-images.githubusercontent.com/21301288/199447142-0c90b200-3976-498e-88e1-dd3c5377ab73.png"> #### Special notes for your reviewer: /cc @halo-dev/sig-halo-console 测试方式： 1. Halo 需要切换到 halo-dev/halo#2652 分支。 2. 检查插件列表的 Logo 是否显示正常。 #### Does this PR introduce a user-facing change? ```release-note None ```
Closed
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
#### What type of PR is this? /kind improvement /milestone 2.0 #### What this PR does / why we need it: 修改插件 Logo 的使用字段为 `status.logo`。用于适配 halo-dev#2652 #### Which issue(s) this PR fixes: Fixes halo-dev#2651 #### Screenshots: <img width="1663" alt="image" src="https://user-images.githubusercontent.com/21301288/199447142-0c90b200-3976-498e-88e1-dd3c5377ab73.png"> #### Special notes for your reviewer: /cc @halo-dev/sig-halo-console 测试方式： 1. Halo 需要切换到 halo-dev#2652 分支。 2. 检查插件列表的 Logo 是否显示正常。 #### Does this PR introduce a user-facing change? ```release-note None ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area core
/milestone 2.0
What this PR does / why we need it:
插件 logo 支持配置外部 URL 或相对于 resources 的路径
Console 端展示插件 logo 时使用的字段需要使用 status.logo 而非 spec.logo
Which issue(s) this PR fixes:
Fixes #2651
Special notes for your reviewer:
how to test it?
/cc @halo-dev/sig-halo
Does this PR introduce a user-facing change?