New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: theme finders supports the reactive API #2695
Conversation
f195eba
to
4dfa559
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
主题各个页面的访问表现正常。
/cc @halo-dev/sig-halo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议提供一些关于自定义SpelExpression 的参考文档。
实现思路: 为了让链式调用可行,可以模仿 MapAccessor 或 JsonPropertyAccessor,它们都是干预表达式解析后 evaluation 值的过程,比如 JsonPropertyAccessor 可以让 SPEL 表达式可以访问 jackson JsonNode 的值,例如有表达式 相关文档 可供参考以下源码: Spring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area core
/milestone 2.0
What this PR does / why we need it:
将所有 Finder 的返回值都修改为 Mono 或 Flux
Which issue(s) this PR fixes:
Fixes #2671
Special notes for your reviewer:
how to test it?
切换几个主题都点一下,没有报错即为正常
/cc @halo-dev/sig-halo
Does this PR introduce a user-facing change?