fix: plugin logo cannot be loaded when it is not enabled #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area core
What this PR does / why we need it:
修复插件 logo 为相对路径时先启用再停后就无法加载 logo 的问题
原因是 reverse proxy reconciler 资源被删除要取消注册路由时没有确切指定名称，logo 这样的 ReverseProxy 是插件安装时初始化的这条初始化的规则要跟随插件的生命周期，只有插件卸载时才会被删除，而在此之前插件被停止时就被误取消注册了
see #2937 for more detail
Which issue(s) this PR fixes:
Fixes #2937
Special notes for your reviewer:
/cc @halo-dev/sig-halo
Does this PR introduce a user-facing change?