Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump uppy version to fix crash on chrome browser #3481

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 8, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

修复在非安全情况下(非 HTTPS 环境或本地环境),在 Chromium 内核的浏览器下拖拽文件上传出现浏览器崩溃的问题。

修复来源:

Which issue(s) this PR fixes:

Fixes #3017

Screenshots:

before:

2023-03-08 10 59 02

after:

2023-03-08 11 00 06

Special notes for your reviewer:

测试方式:

  1. 需要先执行 make -C console install 以更新 Console 的依赖。
  2. 使用非 localhost 或者 127.0.0.1 访问 Halo 后台,本地环境可以使用 192.168.x.x 访问。
  3. 在 Console 的附件管理测试拖拽文件上传,观察浏览器是否崩溃。

Does this PR introduce a user-facing change?

修复非 HTTPS 环境下,在 Chromium 内核浏览器拖拽上传文件时出现浏览器崩溃的问题。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 8, 2023
@ruibaby ruibaby added the area/console Issues or PRs related to the Halo Console label Mar 8, 2023
@ruibaby ruibaby added this to the 2.4.x milestone Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #3481 (d1670bc) into main (633c489) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #3481   +/-   ##
=========================================
  Coverage     61.46%   61.46%           
  Complexity     2477     2477           
=========================================
  Files           393      393           
  Lines         12570    12570           
  Branches       1019     1019           
=========================================
  Hits           7726     7726           
  Misses         4355     4355           
  Partials        489      489           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 80a3fa8 into halo-dev:main Mar 8, 2023
@ruibaby ruibaby deleted the chore/bump-uppy-version branch March 8, 2023 09:32
@ruibaby ruibaby modified the milestones: 2.4.x, 2.4.0 Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console 端的文件上传组件在非 https 环境下使用拖拽上传会导致浏览器崩溃
3 participants