Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.4] Set property server.forward-header-strategy to framework by default #3710

Conversation

halo-dev-bot
Copy link
Collaborator

This is an automated cherry-pick of #3709

/assign JohnNiang

解决反向代理后无法正确获取当前请求 URI 的问题

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 7, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen April 7, 2023 09:31
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #3710 (5d8a63c) into release-2.4 (fe02bd8) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release-2.4    #3710      +/-   ##
=================================================
- Coverage          60.18%   60.03%   -0.16%     
+ Complexity          2258     2253       -5     
=================================================
  Files                341      341              
  Lines              11504    11504              
  Branches             863      863              
=================================================
- Hits                6924     6906      -18     
- Misses              4157     4179      +22     
+ Partials             423      419       -4     

see 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@f2c-ci-robot f2c-ci-robot bot merged commit ed647c2 into halo-dev:release-2.4 Apr 7, 2023
3 checks passed
@ruibaby ruibaby added this to the 2.4.2 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants