Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to initialize the preset plugins #3894

Merged
merged 1 commit into from May 4, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 4, 2023

What type of PR is this?

/kind bug
/area console
/milestone 2.6.x

What this PR does / why we need it:

修复初始化时,预设插件安装失败的问题,目前的解决方案是重试安装操作。

Which issue(s) this PR fixes:

Fixes #3893

Special notes for your reviewer:

测试方式:

  1. 建议参考 https://docs.halo.run/developer-guide/core/build 构建成 Docker 镜像再测试。
  2. 测试初始化完成之后,预设插件是否正确安装以及启动即可。

Does this PR introduce a user-facing change?

修复在初始化时,预设插件可能初始化失败的问题。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 4, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.6.x milestone May 4, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label May 4, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen May 4, 2023 07:16
@ruibaby
Copy link
Member Author

ruibaby commented May 4, 2023

/cherry-pick release-2.5

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #3894 (f441fb6) into main (6789d4c) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3894      +/-   ##
============================================
+ Coverage     60.21%   60.23%   +0.01%     
- Complexity     2331     2332       +1     
============================================
  Files           351      351              
  Lines         12045    12045              
  Branches        877      877              
============================================
+ Hits           7253     7255       +2     
+ Misses         4363     4360       -3     
- Partials        429      430       +1     

see 1 file with indirect coverage changes

@LIlGG
Copy link
Member

LIlGG commented May 4, 2023

/lgtm

测试在 docker 环境下,插件会正常安装、启用。

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@guqing
Copy link
Member

guqing commented May 4, 2023

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 3bfecd2 into halo-dev:main May 4, 2023
4 checks passed
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #3896

In response to this:

/cherry-pick release-2.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request May 4, 2023
This is an automated cherry-pick of #3894

/assign ruibaby

```release-note
修复在初始化时,预设插件可能初始化失败的问题。
```
@ruibaby ruibaby deleted the fix/preset-plugin-setup branch May 7, 2023 07:04
@ruibaby ruibaby modified the milestones: 2.6.x, 2.6.0 May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在初始化时,预设插件可能无法正常安装和启动
4 participants