Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: theme page displays error without management permissions. #3938

Merged
merged 1 commit into from May 15, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented May 12, 2023

What type of PR is this?

/kind bug
/area console
/milestone 2.6.x

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3933

Special notes for your reviewer:

  1. 创建一个拥有主题查看而没有主题管理权限的角色,并为某个用户分配这个角色。
  2. 使用该用户登录 console,点击主题选项卡查看控制台是否报错。

Does this PR introduce a user-facing change?

修复没有主题管理权限时,进入主题功能页面报错的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels May 12, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.6.x milestone May 12, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang May 12, 2023 02:47
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label May 12, 2023
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #3938 (c5a475b) into main (017bb55) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #3938   +/-   ##
=========================================
  Coverage     60.44%   60.44%           
  Complexity     2332     2332           
=========================================
  Files           353      353           
  Lines         12020    12020           
  Branches        872      872           
=========================================
  Hits           7265     7265           
  Misses         4325     4325           
  Partials        430      430           

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 136bd4e into halo-dev:main May 15, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.6.x, 2.6.0 May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

仅有主题查看权限时,进入主题页面报错
3 participants