Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add min and max props for repeater input #3965

Merged
merged 1 commit into from May 25, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 18, 2023

What type of PR is this?

/area console
/kind feature
/milestone 2.6.x

What this PR does / why we need it:

Console 端的 FormKit Repeater 输入框支持 min 和 max 参数用于限制项目数量。

image

Which issue(s) this PR fixes:

Fixes #3449

Special notes for your reviewer:

定义方式:

- $formkit: repeater
  name: test_repeater
  label: 测试 Repeater
  min: 2
  max: 3
  children:
    - $formkit: text
      name: test_text
      label: 测试 Text
    - $formkit: select
      name: test_select
      label: 测试 Select
      options:
        - value: prose-gray
          label: prose-gray
        - value: prose-slate
          label: prose-slate
        - value: prose-zinc
          label: prose-zinc
        - value: prose-neutral
          label: prose-neutral
        - value: prose-stone
          label: prose-stone

Does this PR introduce a user-facing change?

Console 端的 FormKit Repeater 输入框支持 min 和 max 参数用于限制项目数量。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels May 18, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.6.x milestone May 18, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label May 18, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from lan-yonghui and LIlGG May 18, 2023 04:16
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #3965 (e63cfcf) into main (8deea08) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #3965   +/-   ##
=========================================
  Coverage     60.45%   60.45%           
  Complexity     2333     2333           
=========================================
  Files           353      353           
  Lines         12023    12023           
  Branches        873      873           
=========================================
  Hits           7268     7268           
  Misses         4325     4325           
  Partials        430      430           

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 6dd98d2 into halo-dev:main May 25, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.6.x, 2.6.0 May 26, 2023
@ruibaby ruibaby deleted the feat/repater-min-max branch June 1, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

表单定义中的repeater组件增加最小和最大属性限制要添加或删除的项目数量
3 participants