Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add keyword search functionality to AuthProvider list #3974

Merged
merged 2 commits into from May 19, 2023

Conversation

JackyLiang522
Copy link
Contributor

@JackyLiang522 JackyLiang522 commented May 19, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

添加关键字搜索功能到认证方式列表

Which issue(s) this PR fixes:

Fixes #3948

Special notes for your reviewer:

Does this PR introduce a user-facing change?

修复 Console 端认证方式列表无法使用搜索的问题。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 19, 2023
@JackyLiang522 JackyLiang522 changed the title Add keyword search to AuthProvider list fix: add keyword search functionality to AuthProvider list May 19, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wzrove May 19, 2023 07:40
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #3974 (6744366) into main (170cf4e) will increase coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3974      +/-   ##
============================================
+ Coverage     60.47%   60.62%   +0.14%     
- Complexity     2343     2348       +5     
============================================
  Files           355      355              
  Lines         12099    12099              
  Branches        873      873              
============================================
+ Hits           7317     7335      +18     
+ Misses         4350     4331      -19     
- Partials        432      433       +1     

see 5 files with indirect coverage changes

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 19, 2023
@ruibaby ruibaby added the area/console Issues or PRs related to the Halo Console label May 19, 2023
@ruibaby ruibaby added this to the 2.6.x milestone May 19, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit b1d95fe into halo-dev:main May 19, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.6.x, 2.6.0 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

身份认证筛选无效
3 participants