Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix plugin detail page protocol name duplication issue #3977

Merged
merged 1 commit into from May 22, 2023
Merged

fix: fix plugin detail page protocol name duplication issue #3977

merged 1 commit into from May 22, 2023

Conversation

ghost
Copy link

@ghost ghost commented May 21, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

修复插件详情页面协议名字重复出现的问题

Which issue(s) this PR fixes:

Fixes #3971

Special notes for your reviewer:

Does this PR introduce a user-facing change?

修复 Console 端插件详情中的协议出现两次相同内容的问题。

修复插件详情页面协议名字重复出现的问题
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels May 21, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from lan-yonghui and wzrove May 21, 2023 15:16
@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Merging #3977 (0a223b7) into main (b1d95fe) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3977      +/-   ##
============================================
+ Coverage     60.57%   60.62%   +0.04%     
- Complexity     2347     2348       +1     
============================================
  Files           355      355              
  Lines         12099    12099              
  Branches        873      873              
============================================
+ Hits           7329     7335       +6     
+ Misses         4338     4331       -7     
- Partials        432      433       +1     

see 1 file with indirect coverage changes

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2023
@ruibaby ruibaby added this to the 2.6.x milestone May 22, 2023
@ruibaby
Copy link
Member

ruibaby commented May 22, 2023

/cherry-pick release-2.5

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit c22f158 into halo-dev:main May 22, 2023
4 checks passed
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 22, 2023
@ruibaby ruibaby modified the milestones: 2.6.x, 2.6.0 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

插件 license 同时存在 name 与 url 属性时,Console 会重复显示
4 participants