Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text content overflowing the container in the dialog component #4007

Merged
merged 1 commit into from May 29, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 29, 2023

What type of PR is this?

/kind improvement
/area console
/milestone 2.6.x

What this PR does / why we need it:

修复 Console 端 Dialog 对话框组件中的文字内容可能会溢出容器的问题。

before:

image

after:

image

Which issue(s) this PR fixes:

Fixes #4006

Does this PR introduce a user-facing change?

修复 Console 端 Dialog 对话框组件中的文字内容可能会溢出容器的问题。

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 29, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.6.x milestone May 29, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label May 29, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and lan-yonghui May 29, 2023 09:48
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #4007 (cd84a25) into main (937d48b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4007   +/-   ##
=========================================
  Coverage     60.56%   60.56%           
  Complexity     2380     2380           
=========================================
  Files           356      356           
  Lines         12310    12310           
  Branches        891      891           
=========================================
  Hits           7456     7456           
  Misses         4413     4413           
  Partials        441      441           

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit ee1ea06 into halo-dev:main May 29, 2023
4 checks passed
@ruibaby ruibaby deleted the fix/dialog-text-overflow branch May 29, 2023 13:15
@JohnNiang JohnNiang modified the milestones: 2.6.x, 2.6.0 May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console 的 Dialog 组件中的文字内容可能会超出上层容器
3 participants