Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the meta description with special characters causing the page to display abnormally #4031

Merged
merged 1 commit into from Jun 4, 2023
Merged

Fix the meta description with special characters causing the page to display abnormally #4031

merged 1 commit into from Jun 4, 2023

Conversation

Contour-D
Copy link
Contributor

@Contour-D Contour-D commented Jun 2, 2023

What type of PR is this?

/kind bug
/area core

What this PR does / why we need it:

Fix the problem that the meta description with special characters causes the page to display abnormally.
Use htmlEscape in org.springframework.web.util.HtmlUtils to escape the special characters contained in the original description.

see #4000

Which issue(s) this PR fixes:

Fixes #4000

Does this PR introduce a user-facing change?

修复 Meta Description 中含有特殊字符导致页面显示异常的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. area/core Issues or PRs related to the Halo Core labels Jun 2, 2023
@CLAassistant
Copy link

CLAassistant commented Jun 2, 2023

CLA assistant check
All committers have signed the CLA.

@Contour-D
Copy link
Contributor Author

/assign @guqing

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #4031 (54f1831) into main (430b5fb) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #4031      +/-   ##
============================================
- Coverage     60.60%   60.52%   -0.08%     
+ Complexity     2383     2380       -3     
============================================
  Files           356      356              
  Lines         12316    12317       +1     
  Branches        891      891              
============================================
- Hits           7464     7455       -9     
- Misses         4413     4422       +9     
- Partials        439      440       +1     
Impacted Files Coverage Δ
...pp/theme/dialect/ContentTemplateHeadProcessor.java 82.69% <100.00%> (+0.33%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 4, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit a56d4f2 into halo-dev:main Jun 4, 2023
4 checks passed
@Contour-D Contour-D deleted the meta_description_with_special_characters branch June 4, 2023 08:17
@ruibaby
Copy link
Member

ruibaby commented Jun 4, 2023

/cherry-pick release-2.6

@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #4035

In response to this:

/cherry-pick release-2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Jun 4, 2023
…g the page to display abnormally (#4035)

This is an automated cherry-pick of #4031

/assign ruibaby

```release-note
修复 meta description 中含有特殊字符导致页面显示异常的问题
```
@ruibaby ruibaby modified the milestones: 2.7.x, 2.7.0 Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文章内容导致页面显示异常
5 participants