New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the meta description with special characters causing the page to display abnormally #4031
Fix the meta description with special characters causing the page to display abnormally #4031
Conversation
…ses the page to display abnormally
/assign @guqing |
Codecov Report
@@ Coverage Diff @@
## main #4031 +/- ##
============================================
- Coverage 60.60% 60.52% -0.08%
+ Complexity 2383 2380 -3
============================================
Files 356 356
Lines 12316 12317 +1
Branches 891 891
============================================
- Hits 7464 7455 -9
- Misses 4413 4422 +9
- Partials 439 440 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-2.6 |
@ruibaby: new pull request created: #4035 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/area core
What this PR does / why we need it:
Fix the problem that the meta description with special characters causes the page to display abnormally.
Use htmlEscape in org.springframework.web.util.HtmlUtils to escape the special characters contained in the original description.
see #4000
Which issue(s) this PR fixes:
Fixes #4000
Does this PR introduce a user-facing change?