New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make comment subject ref provider extensible #4039
feat: make comment subject ref provider extensible #4039
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov Report
@@ Coverage Diff @@
## main #4039 +/- ##
=========================================
Coverage 60.34% 60.34%
Complexity 2392 2392
=========================================
Files 359 359
Lines 12393 12393
Branches 892 892
=========================================
Hits 7478 7478
Misses 4478 4478
Partials 437 437 |
@ruibaby
|
@guqing 因为无法验证,所以暂时取了 content 作为标题,像 moment 这种没有标题属性的可能用内容也不行,会有很多内容。 可以考虑用时间作为标题,或者取内容的前一部分。 |
如果太长 console 评论列表可以不显示这么多字只显示到可视范围,或者 moment 处理一下截取部分 |
Signed-off-by: Ryan Wang <i@ryanc.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
当前的扩展点是否需要在文档中描述一下呢?
Signed-off-by: Ryan Wang <i@ryanc.cc>
已补充。 |
cc @halo-dev/sig-halo-console |
/lgtm |
What type of PR is this?
/area console
/kind feature
What this PR does / why we need it:
让评论来源的显示支持通过插件扩展,目前如 瞬间 这类的插件如果使用了评论模块,那么在评论管理是无法显示具体来源的:
此 PR 为 Console 端提供了拓展方法,使用方式如下:
Which issue(s) this PR fixes:
Fixes #3554
Special notes for your reviewer:
Does this PR introduce a user-facing change?