New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make plugin tabs extensible #4041
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov Report
@@ Coverage Diff @@
## main #4041 +/- ##
============================================
+ Coverage 60.04% 60.18% +0.14%
- Complexity 2409 2414 +5
============================================
Files 366 366
Lines 12587 12587
Branches 906 906
============================================
+ Hits 7558 7576 +18
+ Misses 4590 4571 -19
- Partials 439 440 +1 |
目前遇到了路由隔离的问题,没有太好的方法实现插件与插件之间定义的 Tab 路由隔离,因为目前插件详情页面是一个父级路由 所以这个 PR 可能得暂时缓缓。 |
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
已经通过重构插件详情页面的路由结构解决此问题,目前插件详情页面仅有一个路由,其他包括设置表单选项卡都是通过路由参数来管理状态,包括此扩展点,重构之后也会让整个结构变得更加清晰。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/milestone 2.8.x
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#### What type of PR is this? /area console /kind improvement /milestone 2.8.x #### What this PR does / why we need it: 简化系统设置页面,选项卡的状态管理逻辑,放弃动态路由的模式,改为使用路由查询参数代替。 原由:#4041 (comment) #### Special notes for your reviewer: 需要测试: 1. 测试系统设置页面能否正常工作即可。 #### Does this PR introduce a user-facing change? ```release-note 重构 Console 端系统设置页面的路由结构 ```
What type of PR is this?
/area console
/kind feature
/milestone 2.7.x
What this PR does / why we need it:
插件自身的详情页面中的 Tabs 选项卡支持拓展,允许开发者自行为插件编写设置界面、一些不常用的操作页面等。
示例:
扩展方式:
参考文档:https://github.com/ruibaby/halo/blob/feat/plugin-tabs-extend/console/docs/extension-points/plugin-self-tabs.md
Which issue(s) this PR fixes:
Fixes #3987
Special notes for your reviewer:
需要测试:
Does this PR introduce a user-facing change?