New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: content page meta tags now override global injected #4069
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4069 +/- ##
============================================
- Coverage 60.19% 60.16% -0.03%
- Complexity 2405 2407 +2
============================================
Files 365 366 +1
Lines 12501 12543 +42
Branches 901 906 +5
============================================
+ Hits 7525 7547 +22
- Misses 4537 4557 +20
Partials 439 439
|
/cherry-pick release-2.6 |
@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
application/src/main/java/run/halo/app/theme/dialect/ContentTemplateHeadProcessor.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/theme/dialect/GlobalHeadInjectionProcessor.java
Show resolved
Hide resolved
@guqing: GitHub didn't allow me to request PR reviews from the following users: halo-dev/sig-halo. Note that only halo-dev members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ruibaby: new pull request created: #4145 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind improvement
/area core
/milestone 2.7.x
What this PR does / why we need it:
修复文章页 HTML Meta 标签重复问题
see #4049 for more details.
Which issue(s) this PR fixes:
Fixes #4049
Does this PR introduce a user-facing change?