Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: content page meta tags now override global injected #4069

Merged
merged 5 commits into from Jun 28, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Jun 13, 2023

What type of PR is this?

/kind improvement
/area core
/milestone 2.7.x

What this PR does / why we need it:

修复文章页 HTML Meta 标签重复问题

see #4049 for more details.

Which issue(s) this PR fixes:

Fixes #4049

Does this PR introduce a user-facing change?

修复文章页 Meta Description 标签重复问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Jun 13, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.7.x milestone Jun 13, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #4069 (3f62e2a) into main (8db4cec) will decrease coverage by 0.03%.
The diff coverage is 95.65%.

@@             Coverage Diff              @@
##               main    #4069      +/-   ##
============================================
- Coverage     60.19%   60.16%   -0.03%     
- Complexity     2405     2407       +2     
============================================
  Files           365      366       +1     
  Lines         12501    12543      +42     
  Branches        901      906       +5     
============================================
+ Hits           7525     7547      +22     
- Misses         4537     4557      +20     
  Partials        439      439              
Impacted Files Coverage Δ
...pp/theme/dialect/ContentTemplateHeadProcessor.java 82.69% <ø> (ø)
...run/halo/app/theme/dialect/GlobalSeoProcessor.java 89.47% <ø> (ø)
...app/theme/dialect/TemplateGlobalHeadProcessor.java 94.44% <ø> (ø)
...pp/theme/dialect/GlobalHeadInjectionProcessor.java 93.93% <86.66%> (-6.07%) ⬇️
...o/app/theme/dialect/DuplicateMetaTagProcessor.java 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@ruibaby
Copy link
Member

ruibaby commented Jun 14, 2023

/cherry-pick release-2.6

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@LIlGG
Copy link
Member

LIlGG commented Jun 26, 2023

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@guqing
Copy link
Member Author

guqing commented Jun 28, 2023

建议在全局注入添加几行 meta 测试
image

/cc @halo-dev/sig-halo

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 28, 2023

@guqing: GitHub didn't allow me to request PR reviews from the following users: halo-dev/sig-halo.

Note that only halo-dev members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

建议在全局注入添加几行 meta 测试
image

/cc @halo-dev/sig-halo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guqing guqing requested review from JohnNiang and ruibaby June 28, 2023 13:59
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 972ebed into halo-dev:main Jun 28, 2023
4 checks passed
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #4145

In response to this:

/cherry-pick release-2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guqing guqing deleted the refactor/4049 branch June 28, 2023 14:54
f2c-ci-robot bot pushed a commit that referenced this pull request Jun 28, 2023
…jected (#4145)

This is an automated cherry-pick of #4069

/assign ruibaby

```release-note
修复文章页 Meta Description 标签重复问题
```
@ruibaby ruibaby modified the milestones: 2.7.x, 2.7.0 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文章页面的 head 标签内出现两个 Meta Description
5 participants