Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump google guava version to 32.0.1-jre #4081

Merged
merged 1 commit into from Jun 15, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Jun 15, 2023

What type of PR is this?

/milestone 2.7.x
/area core

What this PR does / why we need it:

升级 Google Guava 版本至 32.0.1-jre

Guava 31.132.0.1 的变化:

  1. 移除了部分 API 的 @Beta 注解进入稳定版
  2. 关于 Files.createTempDir 方法的安全性修复 GHSA-7g45-4rm6-3mm3 (Security scan reported problem with com.google.common.io.FileBackedOutputStream google/guava#2575)

详情参考:https://github.com/google/guava/releases/tag/v32.0.0

Does this PR introduce a user-facing change?

升级 Google Guava 版本至 32.0.1-jre。

@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 15, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.7.x milestone Jun 15, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from minliacom and ruibaby June 15, 2023 09:50
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #4081 (584ee8a) into main (997a73d) will decrease coverage by 0.07%.
The diff coverage is 12.50%.

@@             Coverage Diff              @@
##               main    #4081      +/-   ##
============================================
- Coverage     60.56%   60.49%   -0.07%     
  Complexity     2386     2386              
============================================
  Files           356      356              
  Lines         12356    12367      +11     
  Branches        894      894              
============================================
- Hits           7483     7482       -1     
- Misses         4432     4444      +12     
  Partials        441      441              
Impacted Files Coverage Δ
...in/java/run/halo/app/plugin/BasePluginFactory.java 11.76% <0.00%> (ø)
...in/java/run/halo/app/plugin/HaloPluginManager.java 6.82% <0.00%> (-0.43%) ⬇️
...pp/core/extension/reconciler/PluginReconciler.java 53.14% <100.00%> (-0.11%) ⬇️

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 350e54d into halo-dev:main Jun 15, 2023
4 checks passed
@guqing guqing deleted the chore/bump-guava branch June 15, 2023 14:58
@ruibaby ruibaby modified the milestones: 2.7.x, 2.7.0 Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants