Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove html lang attribute in console #4085

Merged
merged 1 commit into from Jun 19, 2023

Conversation

longjuan
Copy link
Member

@longjuan longjuan commented Jun 16, 2023

What type of PR is this?

/kind improvement
/area console

What this PR does / why we need it:

去除index.htmllang属性以避免console端出现翻译提示

Which issue(s) this PR fixes:

Fixes #3692

Special notes for your reviewer:

Does this PR introduce a user-facing change?

移除 Console 端页面的 lang 属性,避免出现浏览器的翻译提示。

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 16, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from wan92hen and wzrove June 16, 2023 09:13
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #4085 (cbd04e1) into main (02369fb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4085   +/-   ##
=========================================
  Coverage     60.22%   60.22%           
  Complexity     2385     2385           
=========================================
  Files           357      357           
  Lines         12392    12392           
  Branches        892      892           
=========================================
  Hits           7463     7463           
  Misses         4492     4492           
  Partials        437      437           

@ruibaby ruibaby changed the title perf: Remove fixed html lang attribute perf: remove html lang attribute in console Jun 16, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 1b581d5 into halo-dev:main Jun 19, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.7.x, 2.7.0 Jun 21, 2023
@longjuan longjuan deleted the remove-fixed-lang-attr branch July 1, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

建议提供网站页面语言设置
3 participants