New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: remove html lang attribute in console #4085
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4085 +/- ##
=========================================
Coverage 60.22% 60.22%
Complexity 2385 2385
=========================================
Files 357 357
Lines 12392 12392
Branches 892 892
=========================================
Hits 7463 7463
Misses 4492 4492
Partials 437 437 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area console
What this PR does / why we need it:
去除
index.html
的lang
属性以避免console端出现翻译提示Which issue(s) this PR fixes:
Fixes #3692
Special notes for your reviewer:
Does this PR introduce a user-facing change?