New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude WebSocket request when serving console index #4096
Exclude WebSocket request when serving console index #4096
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4096 +/- ##
============================================
+ Coverage 60.22% 60.25% +0.02%
- Complexity 2385 2392 +7
============================================
Files 357 359 +2
Lines 12392 12393 +1
Branches 892 892
============================================
+ Hits 7463 7467 +4
+ Misses 4492 4490 -2
+ Partials 437 436 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area core
What this PR does / why we need it:
This PR excludes WebSocket request when serving console index and remove request predicate accept in ConsoleProxyFilter.
Which issue(s) this PR fixes:
Fixes #4083
Special notes for your reviewer:
Does this PR introduce a user-facing change?