Refactor setting of problem detail type #4099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note-none
Codecov Report
@@ Coverage Diff @@
## main #4099 +/- ##
============================================
+ Coverage 60.23% 60.44% +0.21%
- Complexity 2385 2389 +4
============================================
Files 357 357
Lines 12397 12388 -9
Branches 892 892
============================================
+ Hits 7467 7488 +21
+ Misses 4493 4461 -32
- Partials 437 439 +2
|
|
已经触发了 Rate Limit 的情况下，当我尝试输入正确的用户名和密码后虽然也出现了异常，但刷新页面会正常跳转到 Console。 
|
|
测试了一下 main 分支也是这样，说明是 #4062 的问题。 |
|
Hi @ruibaby ，确实存在这个问题，稍后我将提交新的 PR 修复这个问题。 |
|
createErrorResponse 方法是否需要放到 Exceptions 中，我看 #4084 中有重复逻辑 |
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Jun 21, 2023
…ted (#4101) #### What type of PR is this? /kind bug /area core #### What this PR does / why we need it: This is a bug introduced from #4062. I have overridden onAuthenticationSuccess to create rate limiter in advance instead of invoking `securityContextRepository#save` before. See #4099 (comment) for more. #### Special notes for your reviewer: 1. Try to log in with incorrect password three times 2. Log in with correct password and check if the response headers contain `Set-Cookie` #### Does this PR introduce a user-facing change? ```release-note None ```
f2c-ci-robot
bot
added
the
approved
|
@JohnNiang 有冲突需要合并 |
Thanks for reminding me! Resolved. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area core
What this PR does / why we need it:
Define a global map to mapping exception to problem detail type.
Does this PR introduce a user-facing change?