Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve the console project infrastructure #4105

Merged
merged 3 commits into from Jun 26, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 21, 2023

What type of PR is this?

/area console
/kind improvement
/milestone 2.7.x

What this PR does / why we need it:

维护 Console 端的开发基础设施。

  • 升级 TypeScript 以及 Vue 对于 TS 支持的相关包。
  • 优化 packages 下所有包的配置,解决构建时生成 d.ts 文件的异常。
  • 解决 TS 异常。

Special notes for your reviewer:

尝试执行:

  1. pnpm build:packages
  2. pnpm typecheck

观察是否正常即可。

Does this PR introduce a user-facing change?

维护 Console 端的开发基础设施。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Jun 21, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.7.x milestone Jun 21, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jun 21, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and QuentinHsu June 21, 2023 08:44
@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2023
@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #4105 (f154e71) into main (f6a6b25) will increase coverage by 0.09%.
The diff coverage is n/a.

❗ Current head f154e71 differs from pull request most recent head acf0c78. Consider uploading reports for the commit acf0c78 to get more accurate results

@@             Coverage Diff              @@
##               main    #4105      +/-   ##
============================================
+ Coverage     60.32%   60.42%   +0.09%     
- Complexity     2391     2395       +4     
============================================
  Files           359      359              
  Lines         12389    12389              
  Branches        892      892              
============================================
+ Hits           7474     7486      +12     
+ Misses         4478     4466      -12     
  Partials        437      437              

see 4 files with indirect coverage changes

Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LIlGG
Copy link
Member

LIlGG commented Jun 26, 2023

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 96225e4 into halo-dev:main Jun 26, 2023
4 checks passed
@ruibaby ruibaby deleted the chore/frontend-infra branch June 26, 2023 03:54
@ruibaby ruibaby modified the milestones: 2.7.x, 2.7.0 Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants