New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add legacy option for useClipboard hook to solve compatibility issues #4114
refactor: add legacy option for useClipboard hook to solve compatibility issues #4114
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov Report
@@ Coverage Diff @@
## main #4114 +/- ##
=========================================
Coverage 60.34% 60.34%
Complexity 2392 2392
=========================================
Files 359 359
Lines 12393 12393
Branches 892 892
=========================================
Hits 7478 7478
Misses 4478 4478
Partials 437 437 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area console
/milestone 2.7.x
What this PR does / why we need it:
Console 端部分使用了复制功能的页面,所使用的 useClipboard hook 添加 legacy 参数以解决部分浏览器的兼容问题。
Which issue(s) this PR fixes:
Fixes #4113
Special notes for your reviewer:
Does this PR introduce a user-facing change?