Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add legacy option for useClipboard hook to solve compatibility issues #4114

Merged
merged 2 commits into from Jun 26, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 25, 2023

What type of PR is this?

/kind improvement
/area console
/milestone 2.7.x

What this PR does / why we need it:

Console 端部分使用了复制功能的页面,所使用的 useClipboard hook 添加 legacy 参数以解决部分浏览器的兼容问题。

Which issue(s) this PR fixes:

Fixes #4113

Special notes for your reviewer:

  1. 使用路由地址(192.168.x.x)访问 Halo。
  2. 测试附件详情弹框的链接复制和概览页面中的复制功能是否正常。

Does this PR introduce a user-facing change?

优化 Console 端部分页面复制功能的兼容性问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Jun 25, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.7.x milestone Jun 25, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from lan-yonghui and LIlGG June 25, 2023 03:26
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #4114 (1bf136f) into main (8c05a6d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4114   +/-   ##
=========================================
  Coverage     60.34%   60.34%           
  Complexity     2392     2392           
=========================================
  Files           359      359           
  Lines         12393    12393           
  Branches        892      892           
=========================================
  Hits           7478     7478           
  Misses         4478     4478           
  Partials        437      437           

@ruibaby ruibaby changed the title refactor: useClipboard add legacy option to solve compatibility issues refactor: add legacy option for useClipboard hook to solve compatibility issues Jun 25, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2023
@LIlGG
Copy link
Member

LIlGG commented Jun 26, 2023

/lgtm

@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@LIlGG
Copy link
Member

LIlGG commented Jun 26, 2023

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 34d0f93 into halo-dev:main Jun 26, 2023
4 checks passed
@ruibaby ruibaby modified the milestones: 2.7.x, 2.7.0 Jun 26, 2023
@ruibaby ruibaby deleted the refactor/useClipboard-legacy branch November 18, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console 部分页面的复制功能可能在非安全域名下失效
4 participants