feat: add support for inserting external media resources to the default editor #4126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt editor Signed-off-by: Ryan Wang <i@ryanc.cc>
f2c-ci-robot
bot
added
kind/feature
f2c-ci-robot
bot
added
the
area/console
Codecov Report
@@ Coverage Diff @@
## main #4126 +/- ##
=========================================
Coverage 60.04% 60.04%
Complexity 2399 2399
=========================================
Files 365 365
Lines 12498 12498
Branches 901 901
=========================================
Hits 7504 7504
Misses 4556 4556
Partials 438 438 |
f2c-ci-robot
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/area console
/area editor
/milestone 2.7.x
What this PR does / why we need it:
默认编辑器支持直接插入图片、视频、音频，提供除了附件库的媒体插入入口。
通过链接插入图片需要 halo-sigs/richtext-editor#17 的支持。
Which issue(s) this PR fixes:
Fixes #3882
Fixes #3994
Special notes for your reviewer:
测试编辑器通过链接插入图片、视频、音频的功能是否正常。
Does this PR introduce a user-facing change?