New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rate limiter for signing up #4128
Add rate limiter for signing up #4128
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4128 +/- ##
============================================
- Coverage 60.20% 60.17% -0.04%
Complexity 2414 2414
============================================
Files 366 366
Lines 12575 12580 +5
Branches 906 906
============================================
- Hits 7571 7570 -1
- Misses 4564 4571 +7
+ Partials 440 439 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area core
/milestone 2.7.x
What this PR does / why we need it:
Add rate limiter for signing up. We only allow 3 registrations within 1 hour by default, despite registration failure.
Special notes for your reviewer:
Does this PR introduce a user-facing change?