New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: plugin path in annotations when plugin installation #4179
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4179 +/- ##
============================================
- Coverage 60.14% 60.13% -0.01%
Complexity 2413 2413
============================================
Files 366 366
Lines 12587 12586 -1
Branches 906 906
============================================
- Hits 7570 7569 -1
Misses 4578 4578
Partials 439 439
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/milestone 2.8.x |
@guqing: once the present PR merges, I will cherry-pick it on top of release-2.7.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works very well.
curl 'http://localhost:8090/apis/api.console.halo.run/v1alpha1/plugins?keyword=&page=1&size=20' \
-s | jq '.items[].metadata.annotations["plugin.halo.run/plugin-path"]'
"PluginStackEdit-1.0.0.jar"
"PluginBytemd-1.2.0.jar"
"app-store-1.0.0-SNAPSHOT.jar"
"PluginSearchWidget-1.0.0.jar"
"PluginSitemap-1.0.2.jar"
"PluginCommentWidget-1.5.0.jar"
"PluginFeed-1.1.1.jar
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm Please note that the current PR may not be cherrypicked to release-2.7. |
@guqing: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind improvement
/area core
/area plugin
/milestone 2.7.x
What this PR does / why we need it:
修复生产模式下插件安装时的位置信息为绝对路径会影响迁移的问题
how to test it?
plugin.halo.run/plugin-path
的值是否为相对于 pluginsRoot 的相对路径plugin.halo.run/plugin-path
是否变为相对路径Which issue(s) this PR fixes:
Fixes #4178
Does this PR introduce a user-facing change?