Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow switching editors while editing a post #4180

Merged
merged 3 commits into from Jul 18, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 5, 2023

What type of PR is this?

/area console
/kind feature
/milestone 2.8.x

What this PR does / why we need it:

支持在编辑文章时切换编辑器,不再限制仅新建时允许切换。但需要注意的是,目前只支持同类型的编辑器切换(rawType)。

Which issue(s) this PR fixes:

Fixes #4176

Special notes for your reviewer:

测试方式:

  1. 安装多个编辑器插件,可以在 https://github.com/halo-sigs/awesome-halo 中查找。
  2. 测试在新建文章时是否能够正常切换编辑器。
  3. 测试在修改文章时能够正常切换同类型的编辑器。

Does this PR introduce a user-facing change?

Console 端编辑文章时允许同类型的编辑器切换。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 5, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.8.x milestone Jul 5, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #4180 (0a5f815) into main (bf2b92e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4180   +/-   ##
=========================================
  Coverage     60.04%   60.04%           
  Complexity     2409     2409           
=========================================
  Files           366      366           
  Lines         12587    12587           
  Branches        906      906           
=========================================
  Hits           7558     7558           
  Misses         4590     4590           
  Partials        439      439           

@LIlGG
Copy link
Member

LIlGG commented Jul 12, 2023

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit e6f3175 into halo-dev:main Jul 18, 2023
4 checks passed
@ruibaby ruibaby deleted the feat/editor-switch branch July 18, 2023 08:16
@ruibaby ruibaby modified the milestones: 2.8.x, 2.8.0 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望文章编辑页面支持同类型(rawType)编辑器的切换
4 participants